search

phatworx / devise_security_extension

An enterprise security extension for devise, trying to meet industrial standard security demands for web applications.
MIT License
748 stars 347 forks source link

Replace Fixnum references #232

Closed 3zcurdia closed 6 years ago

3zcurdia commented 6 years ago

It replaces references Fixnum references from ruby 2.4. It closes #231

Gasparila commented 6 years ago

@alexdreher any way we can get this merged?

vimutter commented 6 years ago

@3zcurdia I think you need to update Gemfile for 2.4. Do you need help with that?

erolms commented 6 years ago

Folks, when can we get this commit merged into master?

Gasparila commented 6 years ago

Until this is merged, we "fixed" the deprecation warnings by adding Devise::Models::PasswordArchivable.const_set("Fixnum", Integer) to the devise initializer file

erolms commented 6 years ago

In my case I had to add Devise::Models::PasswordExpirable.const_set("Fixnum", Integer) too. Working like a charm, thanks!

tibbon commented 6 years ago

What's the status of this?

3zcurdia commented 6 years ago

closing this PR in favor of #238