search

phenopackets / phenopacket-schema

Repository for the GA4GH phenopacket schema
https://phenopacket-schema.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
79 stars 30 forks source link

MedicalAction action field in doc could be changed to a more detailed field #347

Open belkassaby opened 2 years ago

belkassaby commented 2 years ago

In MedicalAction, there is the "action" field which can be either of type Procedure, Treatment, RadiationTherapy or TherapeuticRegimen. Instead of it being named "action" (in a phenopacket json file that is generated with the phenopacket-tools, there is no such field/id), we could indicate that the id in the corresponding json is either "procedure", "treatment", "radiationTherapy" or "therapeuticRegimen".

pnrobinson commented 2 years ago

I do not think we want to make what would be a breaking change in the schema. Software should be able to make this obvious to users?

belkassaby commented 2 years ago

I meant that the changes could be done in the doc instead of the software side.