search

phetsims / aqua

Automatic QUality Assurance
MIT License
2 stars 4 forks source link

CT: Add tests to build/lint/tsc sims with only dependencies checked out #202

Closed zepumph closed 5 months ago

zepumph commented 5 months ago

From https://github.com/phetsims/perennial/issues/347. We lint/tsc on release branches, and it would be best to be testing this when only dependencies are checked out. It would caught https://github.com/phetsims/phetcommon/issues/63 eagerly, and also aligns with open source/POSE related goals.

zepumph commented 5 months ago

https://github.com/phetsims/perennial/issues/347#issuecomment-1879175653 is a bad first patch. Likely going fresh is best.

zepumph commented 5 months ago

While this would be helpful, it doesn't seem valuable enough to create so much space burden (perhaps 2 orders of magnitude more space with 100 copies of chipper/node_modules/dist checked out).

I'm going to close this issue as a wontfix, and we can pick things up in https://github.com/phetsims/aqua/issues/203. That issue will at least catch this once the release branch is created.