search

phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

NucleonArrowButtons.toggleCreatorNodeEnabled() is a side effect in a DerivedProperty #170

Closed zepumph closed 1 year ago

zepumph commented 1 year ago

Discovered while working on https://github.com/phetsims/build-a-nucleus/issues/169. In general this is a code smell. Let's see if we can remedy that.

zepumph commented 1 year ago

And don't forget about https://github.com/phetsims/build-a-nucleus/issues/185 as part of this work.

zepumph commented 1 year ago

https://github.com/phetsims/build-a-nucleus/issues/185 unblocked this work quite a bit. I'd like to look into this.

zepumph commented 1 year ago

Working on this now.