search

phetsims / build-a-nucleus

"Build a Nucleus" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 5 forks source link

Dynamically changing locales causes inconsistent radio button sizes #178

Closed jbphet closed 1 year ago

jbphet commented 1 year ago

Found during code review, see #165.

When the locale is changed dynamically it can cause the radio button sizes to be inconsistent. There are a couple of screenshots below to illustrate. This is a know common code issue, see https://github.com/phetsims/sun/issues/852, but I thought I should log it so that the designer can decide how important it is to get this fixed before publication.

To illustrate, here is an example of the "Available Decays" panel when launched with locale=de (German):

image

Here's what this panel looks like if launched with locales=* and then the locale is changed to Deutsch (German):

image

jbphet commented 1 year ago

Here are a couple of other examples that look a bit worse.

Kurdish:

image

French:

image

jbphet commented 1 year ago

Assigning to the people that I think did the design to prioritize this. They can pass it on as appropriate.

zepumph commented 1 year ago

@Luisav1 and I would like to pair on this so she can get a glimpse at some of the i18n dynamic locale work.

Luisav1 commented 1 year ago

@zepumph and I fixed this in the commit above. Closing.