phetsims / energy-skate-park-basics

"Energy Skate Park: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/energy-skate-park-basics
GNU General Public License v3.0
2 stars 9 forks source link

Can proxy for save/load for the tracks for phetio.js be removed? #405

Closed jessegreenberg closed 6 years ago

jessegreenberg commented 6 years ago

This block is in EnergySkateParkBasicsModel

    // Proxy for save/load for the tracks for phetio.js
    // TODO: This is all a bit hackish, to serialize the tracks.  Cannot this be made simpler?
    if ( draggableTracks ) {
      //phetio && phetio.addInstance( 'playgroundScreen.tracks', {
      //  phetioID: 'playgroundScreen.tracks',
      //
      //  // TODO: use get value instead of this function.
      //  getArray: function() {
      //  },
      //
      //  get value() {
      //    return this.getArray();
      //  },
      //
      //  // TODO: set value asymmetric from getArray
      //  set value( arrayOfArrayOfVector ) {

      //  }
      //} );
    }

Not sure if we still want this around. @samreid would you like to keep this commented code?

jessegreenberg commented 6 years ago

For #398.

samreid commented 6 years ago

It can be deleted now, thanks!

jessegreenberg commented 6 years ago

Deleted, closing.