search

phetsims / energy-skate-park-basics

"Energy Skate Park: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/energy-skate-park-basics
GNU General Public License v3.0
2 stars 9 forks source link

Consolidate options in ScreenViews for this sim #463

Closed jessegreenberg closed 5 years ago

jessegreenberg commented 5 years ago

The options in IntroScreenView, FrictionScreenView, and PlaygroundScreenView are identical, and these types are mostly the same too. This happened after code was moved to enegy-skate-park, and these options configure the "basics" ScreenViews. Maybe consolidate options or create new types liek EnergySkateParkBasicsTrackSetScreenView.

I think I prefer moving and reuising the shared options because it will work for all three ScreenViews.

jessegreenberg commented 5 years ago

This is done, I went with a separate type because the EnergySkateParkBasicsTrackSetScreenView has its own EnergyBarGraphPanel, not just unique options.