search

phetsims / faradays-electromagnetic-lab

"Faraday's Electromagnetic Lab" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
1 stars 0 forks source link

Change cursor appearance when bar magnet is locked to axis #184

Closed Nancy-Salpepi closed 2 weeks ago

Nancy-Salpepi commented 3 weeks ago

Test device MacBook Air M1 chip

Operating System 14.5

Browser Safari 17.5

Problem description For https://github.com/phetsims/qa/issues/1091, on the Pickup Coil Screen when 'Lock to Axis' is checked, the cursor is a hand when hovering over the bar magnet. Hovering the cursor over the Pickup Coil and Electromagnet on the Pickup Coil and Transformer Screens shows a double-sided arrow, while freely moving objects, such as the compass, have the hand cursor. Shouldn't the cursor for the bar magnet also show a double-sided arrow since its movement is now limited to the axis?

Steps to reproduce

  1. On the Pickup Coil Screen, check 'Lock to axis'
  2. Hover pointer over the magnet.

Visuals

https://github.com/phetsims/faradays-electromagnetic-lab/assets/87318828/09f8e3d6-5b2f-412c-8509-f2aa68075b96

arouinfar commented 3 weeks ago

Shouldn't the cursor for the bar magnet also show a double-sided arrow since its movement is now limited to the axis?

Good catch! Looks like an oversight. @pixelzoom let's use the double-headed arrow when Lock to Axis is on.

pixelzoom commented 2 weeks ago

Fixed in the above commit. @Nancy-Salpepi please review in main, close if OK.

Nancy-Salpepi commented 2 weeks ago

Looks good. Closing.