search

phetsims / fluid-pressure-and-flow

"Fluid Pressure and Flow" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 5 forks source link

Does config file need underscore under "shim" property? #304

Open zepumph opened 7 years ago

zepumph commented 7 years ago

In the config.js file, I see this entry:

  shim: {
    underscore: { exports: '_' }
  },

I only see it in two other sims: states-of-matter and atomic-interactions. Is this needed?

I know that lodash is a preload, so perhaps this was before that time? @jbphet can you clarify since states-of-matter and atomic-interactions are both your sims?

jbphet commented 7 years ago

The shim entries shouldn't need to be there in states-of-matter and atomic-interactions since underscore is a preload. I removed them and did a bit of testing on both, and didn't see any problems. I would expect that it's probably safe to do the same for FPAF.