search

phetsims / fluid-pressure-and-flow

"Fluid Pressure and Flow" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
8 stars 5 forks source link

There are translations for this sim, and it hasn't be published. What should we do? #337

Closed jbphet closed 2 years ago

jbphet commented 2 years ago

@liam-mulhall was working on https://github.com/phetsims/website/issues/1362, and he discovered that there were quite a number of translations for this sim, yet to my knowledge, it has never been published. Have a look at https://github.com/phetsims/babel/tree/master/fluid-pressure-and-flow to see the list of translated string files.

So, a couple of question arise:

Does anyone know how this might have happened? Was this sim published as a prototype or something?

Should these be deleted, or should we keep them around for when the sim is published? It will be a bit of an issue if any strings change or are added, because we will end up with a bunch of partial translations if these are kept.

Assigning to the responsible dev for this repo.

zepumph commented 2 years ago

There are no deploys of this sim on phet.colorado.edu/sim/html. Looking at the commit history for babel/fluid-pressure-and-flow, it looks like translators seems to be available to clients somehow? Does it have something to do with access to rosetta from the java version, but then saved into babel? FPAF has not had a prototype, it is still far from complete.

Likely we should make sure that there isn't still access to translate this sim first.

From there, we can discuss removing the current translations. The sim is basically feature complete to my knowledge, and likely its strings won't change all that much. Perhaps we should make an issue to review how similar the translations are upon publications. I'm happy to just delete them too if you prefer, since some of the translations are from quite some time ago (2016), well before I was the responsible dev for it.

jbphet commented 2 years ago

Okay, I think I've solved the mystery here. The under-pressure sim is published, and it is a subset of fluid-pressure-and-flow, so many of its strings for under-pressure are stored in the fluid-pressure-and-flow section of the babel repo. The translations that we're seeing here have been for under-pressure, which is fine. We've just never run into a case where a subset sim has been published for years without the full sim ever going live, so it threw us.

I just looked through the translation files in the under-pressure sim, and something is a bit odd about some of them. There is more in some of them than I would expect. I'll log a separate issue to follow up on that when and if fluid-pressure-and-flow is published, but will mark is as deferred since I don't think it is pressing.

So, in the end, this is a non-problem. I'd like @zepumph and @liam-mulhall to read through this so that we are all clear on it, at which point this can be closed.

Last one out please turn off the lights.

liammulh commented 2 years ago

For some reason, I am unable to edit your comment @jbphet. I think this might have to do with my GitHub team settings? Not sure. In any case, I've read through the issue and I'm happy to close it.