Open oliver-phet opened 2 years ago
This is an interesting suggestion. We should consider it the next time this sim is resisting. Unassinging myself for now.
Tagging for design meeting to discuss if we want to address this with https://github.com/phetsims/forces-and-motion-basics/issues/304
Discussed, and agreed we should add a stopwatch to the Motion and Friction screens. The checkbox can go right below the Speed checkbox. We like the icon. The stopwatch can go in the sky to the left of the panel.
Addressed in the above commit. Please keep in mind that neither the Stopwatch (element in the model that keeps track of time), nor the StopwatchNode (node in the view which displays the tool) have tandem on them. The checkbox on the other hand did get a tandem, since the constructor was clear enough for me to infer the appropriate tree structure.
If you need PhET-iO for this feature, please let me know the specs. Otherwise, please review and close if OK.
The stopwatch looks good to me. @arouinfar or @kathy-phet any thoughts about the phet-io question?
The stopwatch also looks good to me. The PhET-iO instrumentation of this sim predates Hydrogen and our modern design processes. It will be a significant effort to republish this simulation with PhET-iO, and we're only including phet-brand in the upcoming release, so I think we can defer instrumenting the Stopwatch until later.
The Stopwatch should be tested during the QA process, so assigning back to @AgustinVallejo to make sure this is on the list of issues for QA during dev testing.
As the region and culture publication won't include PhET-iO, keeping this as ready for review by QA during dev testing and unassigning @AgustinVallejo and @kathy-phet.
Assigning to @arouinfar for evaluation.