phetsims / forces-and-motion-basics

"Forces and Motion: Basics" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/forces-and-motion-basics
GNU General Public License v3.0
7 stars 10 forks source link

Move phet-io-wrapper-classroom-activity to live in phet-io-sim-specific #300

Open samreid opened 1 year ago

samreid commented 1 year ago

As described in https://github.com/phetsims/phet-io-sim-specific/issues/1#issuecomment-1215128095, we should Move phet-io-wrapper-classroom-activity to live in phet-io-sim-specific. Ideally scouring the maintenance releases for references to the phet-io-wrapper-classroom-activity so it can be removed as a dependency.

zepumph commented 4 months ago

For now I recommend removing this wrapper from package.json. It doesn't need any more work than that to release us from the maintenance burden that a new release will incur if we keep it as a dependency. @samreid, does that seem like a reasonable path forward until we next need to care about the classroom activity wrapper?


Subject: [PATCH] fhdsajfkdsl
---
Index: package.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/package.json b/package.json
--- a/package.json  (revision 28e73be871e0630a11fe20da23c0e5a0dd2bdf8d)
+++ b/package.json  (date 1713823944540)
@@ -30,10 +30,7 @@
     },
     "simulation": true,
     "phet-io": {
-      "validation": false,
-      "wrappers": [
-        "phet-io-wrapper-classroom-activity"
-      ]
+      "validation": false
     },
     "supportsOutputJS": true,
     "published": true,
samreid commented 4 months ago

Yes, sounds good, thanks!

Luisav1 commented 4 months ago

The classroom activity wrapper has been removed from package.json, resolving the dependency issue. Thus, this no longer blocks publication. I'll leave this issue open and deferred until there's a need to address the classroom activity wrapper again. Thanks for the collaboration!