Open samreid opened 1 year ago
For now I recommend removing this wrapper from package.json. It doesn't need any more work than that to release us from the maintenance burden that a new release will incur if we keep it as a dependency. @samreid, does that seem like a reasonable path forward until we next need to care about the classroom activity wrapper?
Subject: [PATCH] fhdsajfkdsl
---
Index: package.json
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/package.json b/package.json
--- a/package.json (revision 28e73be871e0630a11fe20da23c0e5a0dd2bdf8d)
+++ b/package.json (date 1713823944540)
@@ -30,10 +30,7 @@
},
"simulation": true,
"phet-io": {
- "validation": false,
- "wrappers": [
- "phet-io-wrapper-classroom-activity"
- ]
+ "validation": false
},
"supportsOutputJS": true,
"published": true,
Yes, sounds good, thanks!
The classroom activity wrapper has been removed from package.json
, resolving the dependency issue. Thus, this no longer blocks publication. I'll leave this issue open and deferred until there's a need to address the classroom activity wrapper again. Thanks for the collaboration!
As described in https://github.com/phetsims/phet-io-sim-specific/issues/1#issuecomment-1215128095, we should Move phet-io-wrapper-classroom-activity to live in phet-io-sim-specific. Ideally scouring the maintenance releases for references to the phet-io-wrapper-classroom-activity so it can be removed as a dependency.