Closed phet-steele closed 7 years ago
In both of these situations, the line should travel flat along the x axis whenever it has exceed the min/max y values.
@aadish, I actually like what the Java does better. When the graph exceeds the max y, the line is clipped:
We should do that, too. However, we should keep the behaviour I suggested for the min y values (a flat line)
I love it! Thanks @aadish.
The average protein level can go both above and below the graph. The values should probably stay clamped so this does not occur.
Just let one cell run over time (with optimal protein synthesis conditions) and eventually this will happen:
Here, also let one cell run. Make it lose all of its protein and the line will dip below the graph (for demonstration, I then kicked the cell back into high gear to show the line had indeed gone below the graph).
In both of these situations, the line should travel flat along the x axis whenever it has exceed the min/max y values.
Seen on macOS 10.12.3 Chrome and by @BryceAG on Win 7. For phetsims/tasks/issues/776.
URL: http://www.colorado.edu/physics/phet/dev/html/gene-expression-essentials/1.0.0-dev.2/gene-expression-essentials_en.html Version: 1.0.0-dev.2 2017-01-30 19:21:44 UTC Features missing: touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36 Language: en-US Window: 1414x1001 Pixel Ratio: 2/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 32 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 80) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {"assert":{"sha":"a707328c","branch":"master"},"axon":{"sha":"1cf10281","branch":"master"},"babel":{"sha":"10f77fec","branch":"master"},"brand":{"sha":"0be722ee","branch":"master"},"chipper":{"sha":"f4cd39bf","branch":"master"},"dot":{"sha":"75380061","branch":"master"},"gene-expression-essentials":{"sha":"9e5baa27","branch":"master"},"joist":{"sha":"d15e6fab","branch":"master"},"kite":{"sha":"6059ebb0","branch":"master"},"phet-core":{"sha":"84747dff","branch":"master"},"phetcommon":{"sha":"1cb33196","branch":"master"},"query-string-machine":{"sha":"d8a4ff18","branch":"master"},"scenery":{"sha":"550df01a","branch":"master"},"scenery-phet":{"sha":"b04d8086","branch":"master"},"sherpa":{"sha":"785a536c","branch":"master"},"sun":{"sha":"d0708aa5","branch":"master"},"tandem":{"sha":"d9c124e5","branch":"master"}}