search

phetsims / john-travoltage

"John Travoltage" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/john-travoltage
GNU General Public License v3.0
4 stars 8 forks source link

Many hard coded strings #444

Closed zepumph closed 3 years ago

zepumph commented 3 years ago

I found that there are some hard coded string in JohnTravoltageView.js while working on https://github.com/phetsims/utterance-queue/issues/13. For example https://github.com/phetsims/john-travoltage/blob/69df7131ce4415879f71aedb76ef2b77b585e20e/js/john-travoltage/view/JohnTravoltageView.js#L406, shouldn't these be in the strings file?

jessegreenberg commented 3 years ago

Thanks, yes they should. These strings were added quickly in support of vibration prototypes. But we are no longer testing different "vibration paradigms" and most code under vibrationParam check just be removed. That leaves this string as the one that needs to me moved to the strings file

https://github.com/phetsims/john-travoltage/blob/58941475208dff4c71e1bb812d146c198e054a5e/js/john-travoltage/view/JohnTravoltageView.js#L488

jessegreenberg commented 3 years ago

Thanks @zepumph, strings either removed or moved to strings file.