search

phetsims / joist

Joist is the main framework for PhET Interactive Simulations. Joist creates and displays the simulation content, home screen, navigation bar, About dialog, enables switching between tabs, and other framework-related features.
MIT License
8 stars 6 forks source link

Preferences Dialog: Needs to respect UI Sound On/Off #870

Closed kathy-phet closed 1 year ago

kathy-phet commented 1 year ago

We found in Number Play that the Preferences Dialog plays UI sound and isn't respecting UI Sound On/Off list.

jessegreenberg commented 1 year ago

I think TabSwitchSoundGenerator was the only item missing a categoryName, @jbphet can you please confirm that this commit is correct?

jbphet commented 1 year ago

Yes, the commit looks correct to me. I also tested it by verifying that no UI sounds are being produced by the Preferences dialog in the number-play sim, then commented out the line soundManager.setOutputLevelForCategory( 'user-interface', 0 ); from number-play-main.ts and verified that the sounds play normally. It all worked as expected. Back to you @jessegreenberg in case there is anything else on this.

jessegreenberg commented 1 year ago

Thanks for reviewing @jbphet. I think that was all for this one, @kathy-phet @amanda-phet @chrisklus FYI this was done.