search

phetsims / molecule-polarity

"Molecule Polarity" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 6 forks source link

Uninstrument bondDipolesCheckbox.labelNode.labelIcon #116

Closed arouinfar closed 3 years ago

arouinfar commented 3 years ago

Discovered during #104

The icon next to the "Bond Dipole" checkbox is instrumented, though the same was not done for the "Molecular Dipole" checkbox. For consistency, the icons should be treated the same. @kathy-phet and I didn't see any particular reason why the icon needs to be instrumented separately from the checkbox, so we'd like to uninstrument moleculePolarity.*Screen.view.controlPanel.viewControls.bondDipoleCheckbox.labelNode.labelIcon.

pixelzoom commented 3 years ago

Done, @arouinfar please verify in master. If it looks OK, you can close this issue.

arouinfar commented 3 years ago

Looks good, thanks @pixelzoom