search

phetsims / molecules-and-light

"Molecules and Light" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
2 stars 5 forks source link

Light Spectrum dialog - content create/review #304

Closed terracoda closed 4 years ago

terracoda commented 4 years ago

@BLFiedler is completing the content for the Light Spectrum dialog in the design doc.

We should review:

brettfiedler commented 4 years ago

H2 completed on my end for now. Left an indented bullet list as well as a version laid out in sentence structure.

terracoda commented 4 years ago

@jessegreenberg, @BLFiedler has completed the detailed descriptions for the light spectrum dialog here in the design doc.

Is it possible to do a nested list structure like Brett created under the bolded text, "H2: Frequency and Wavelength Ranges"? I think that structure could make reading and skipping lines easier for screen reader users.

terracoda commented 4 years ago

@Matthew-Moore240, you are still welcome to read/review the content and comment if you like.

jessegreenberg commented 4 years ago

It is possible. The descriptions have been added to the sim, and the PDOM looks like this when the spectrum dialog is open: image

Back to @BLFiedler and @terracoda for review.

brettfiedler commented 4 years ago

Looks great to me. I'll leave it up to Taliesin if that seems like it'll work well to navigate via screen reader.

terracoda commented 4 years ago

@BLFiedler, for the Visible light description, how do you about feel putting the rainbow description as the first sub-bullet? It is new info, not following the same pattern as the other light sources. I think it could be skipped over easily if it is the third bullet.

With the change, it would read like this:

And since the entire graph is shown low to high energy, do you think it is necessary to repeat that for visible light? How does this sound?

@BLFiedler assigning to you to verify wording and order changes.

brettfiedler commented 4 years ago

Visible, tiny range: Shown as a rainbow of colors (dark red to red to orange to yellow to green to blue to violet). Frequencies 4 times 10 to the 14 to 7 times 10 to the 14 Hertz. Wavelengths 7 times 10 to the negative 7 to 4 times 10 to the negative 7 meters.

I think that's a good idea. I agree it could be easily skipped. Everything (frequencies, wavelengths, light spectra) is listed low to high energy, so I agree it's not necessary to re-state.

terracoda commented 4 years ago

@jessegreenberg, could you adjust the content so it is the same as the group in https://github.com/phetsims/molecules-and-light/issues/304#issuecomment-604079253

jessegreenberg commented 4 years ago

OK, change made in the above commit! Can this be closed @terracoda?

terracoda commented 4 years ago

Looks good. Closing time.