phetsims / natural-selection

"Natural Selection" is an educational simulation in HTML5, by PhET Interactive Simulations
GNU General Public License v3.0
3 stars 7 forks source link

Diff wrapper `getPhetioAPI` assumes a relative path for API file #274

Closed pixelzoom closed 3 years ago

pixelzoom commented 3 years ago

This issue is to track https://github.com/phetsims/phet-io-wrappers/issues/405 for Natural Selection 1.3.

In https://github.com/phetsims/phet-io-wrappers/issues/405#issuecomment-826008418, @zepumph described that issue as blocking:

I also saw that this is a actually completely different problem from what was originally reported in phetsims/natural-selection#271, and the "APIs are identical" output was actually because of a bug where the "other sim URL" was loading the SAME (this sim's) API file instead of going out and grabbing the other sim's api. I created #406 to solve that, which is also blocking. To fix that, we need this issue to be working though, so both bugs are important improvements, and both blocking NS release.

In 4/23/21 Slack, @zepumph didn't say whether that issue is blocking:

Updates about blocking issues: ...

@zepumph @kathy-phet please clarify: Is this blocking for NS 1.3 ?

pixelzoom commented 3 years ago

Closing, this can be tracked in #271. See https://github.com/phetsims/natural-selection/issues/271#issuecomment-827045685.