phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Label above value in distance statement doesn't update #82

Closed Nancy-Salpepi closed 9 months ago

Nancy-Salpepi commented 9 months ago

Test device MacBook Air M1 chip

Operating System 14.1.1

Browser Safari 17.1

Problem description For https://github.com/phetsims/qa/issues/1005, on both screens and in all scenes, if only one object is in the play area, switching which variable (ex. x1 or x2 )is assigned to which object (ex. house or person) doesn't change the label in the distance statement. This isn't an issue when both objects are in the play area.

Steps to reproduce Here is an example:

  1. In the first scene of the Explore screen, place the house on -3 --The distance statement will show an x1 above the -3.
  2. Switch the objects, so that the house is now x2. -- The distance statement will not show "x2" above -3. Instead it still has "x1" above x1.

Visuals Dev version:

Screenshot 2023-11-27 at 9 19 09 AM

Published:

Screenshot 2023-11-27 at 9 22 29 AM
marlitas commented 9 months ago

Fixed in the below commit. Over to @Nancy-Salpepi to check on main and close if all looks well. Thanks!

Nancy-Salpepi commented 9 months ago

Looks good! Closing.