search

phetsims / number-line-distance

"Number Line: Distance" is an educational simulation in HTML5, by PhET Interactive Simulations.
GNU General Public License v3.0
0 stars 3 forks source link

Should touch/pointer areas be the same width for checkboxes? #85

Closed Nancy-Salpepi closed 8 months ago

Nancy-Salpepi commented 9 months ago

For https://github.com/phetsims/qa/issues/1009 I have the same question as in https://github.com/phetsims/number-line-integers/issues/124. Wondering if the touch/pointer areas for checkboxes should all be the same width?

Screenshot 2023-12-08 at 9 31 26 AM
marlitas commented 9 months ago

This was fixed in: https://github.com/phetsims/number-line-integers/issues/124. Should be cherry picked here as well.

marlitas commented 8 months ago

cherry picked for https://github.com/phetsims/qa/issues/1018. Feel free to close if all looks well.

Nancy-Salpepi commented 8 months ago

The touch area and the pointer area are the same size now but the area for each checkbox is still different. I thought the areas for each checkbox were usually the same size (a short word would have a touch/pointer area that is the same size as a long word), but maybe that isn't standard? Feel free to close if that is not the case. Ex. CaV:

Screenshot 2023-12-21 at 8 53 02 AM
marlitas commented 8 months ago

I believe that's the case when using VerticalCheckboxGroup which the Number Line sims do not use. I don't believe that's prohibitive here, although it may want to be refactored in the future it was outside the scope of this publication to address full refactors like that. Closing.