search

phetsims / paper-land

Build and explore multimodal web interactives with pieces of paper!
https://phetsims.github.io/paper-land/
MIT License
20 stars 3 forks source link

Change "Description" to "Speech" in View Component form #251

Closed brettfiedler closed 6 months ago

brettfiedler commented 6 months ago

I believe "Speech" is more recognizable and more acutely the technology we're tapping into with this component. In PhET's use, we will use the "Speech" component to create description and Voicing-like interactions, but I think the "Description" terminology is likely to be confusing to others.

jessegreenberg commented 6 months ago

OK, Ill rename. Would be best to rename the code references as well.

jessegreenberg commented 6 months ago

This was done in the above commit, renamed to 'speech' in the UI and in all code references (DescriptionViewComponent -> SpeechViewComponent, and in generated code).

jessegreenberg commented 2 months ago

The rename also hit serialization, breaking old saves that saved things under descriptionViews. The above commit is a graceful fallback for that old data.

Its kind of ugly to do this in the loading part of the code, maybe someday there will be better migration support when the data changes.