phetsims / paper-land

Build and explore multimodal web interactives with pieces of paper!
https://phetsims.github.io/paper-land/
MIT License
18 stars 3 forks source link

Improve how the space data is updated in the Camera screen #78

Open jbphet opened 1 year ago

jbphet commented 1 year ago

Currently, the space data in the camera screen is updated using a method called _pollSpaceUrl. There are a few problems with the way this works, and I think I just ran into one of them. The problems are:

jbphet commented 1 year ago

I've implemented this. So far, I like it a lot. I'm not longer able to create situations with competing and out-of-sync requests for space updates, and the polling stops when the tab is not visible.

Assigning to @BLFiedler and @jessegreenberg to review the concept and the code changes. We should also decide if the same thing should be done for the Editor page.

jessegreenberg commented 1 year ago

Nice, that looks great! Its been working well for some time now. Even though you can't change spaces on the Editor page, the second two benefits in https://github.com/phetsims/paper-land/issues/78#issue-1673911043 make me think its worth it to o the same change for the Editor page.

brettfiedler commented 1 month ago

We've deemphasized Editor in favor of Creator, but should anyone use Paper Playground and want more functionality from the Editor, they might consider implementing this. Leaving as a wishlist.