phetsims / perennial

Maintenance tools that won't change with different versions of chipper checked out
http://scenerystack.org/
MIT License
5 stars 5 forks source link

lint bug in `release-branches/` #400

Open zepumph opened 4 months ago

zepumph commented 4 months ago

While @jonathanolson was working on the MR for https://github.com/phetsims/scenery/issues/1643, linting hookes-law 1.1 (unpublished) failed with this error:

Running "lint-all" task
[........................................] 100.00%

/Users/jon/phet/git/release-branches/hookes-law-1.1/chipper/js/grunt/typescript-test.ts
  0:0  error  Parsing error: ESLint was configured to run on `<tsconfigRootDir>/js/grunt/typescript-test.ts` using `parserOptions.project`: /users/jon/phet/git/release-branches/hookes-law-1.1/chipper/tsconfig/all/tsconfig.json
However, that TSConfig does not include this file. Either:
- Change ESLint's list of included files to not include this file
- Change that TSConfig to include this file
- Create a new TSConfig that includes this file and include it in your parserOptions.project
See the typescript-eslint docs for more info: https://typescript-eslint.io/linting/troubleshooting#i-get-errors-telling-me-eslint-was-configured-to-run--however-that-tsconfig-does-not--none-of-those-tsconfigs-include-this-file

✖ 1 problem (1 error, 0 warnings)

Fatal error: Lint failed

We cannot reproduce on main, and we cannot reproduce with grunt checkout-target --target=1.1 --repo=hookes-law, so we are thinking it has something to do with the release inside the release-branches/ directory.

zepumph commented 4 months ago

This should block the creation of a release branch, at least until speaking to @samreid or @zepumph.

zepumph commented 4 months ago

Ok. This fixes the issue, but we never really got to the bottom of why this isn't reproducible on main.

@samreid mentioned we may want to try to upgrade out lint and typescript packages to see if that helps.

zepumph commented 4 months ago

This is something to note when we start working on https://github.com/phetsims/chipper/issues/1437 again.

zepumph commented 4 months ago

Now that there is a workaround to unblock the MR, I'll unassign until we work on https://github.com/phetsims/chipper/issues/1437