search

phetsims / rosetta

PhET's Simulation Translation Utility
MIT License
3 stars 1 forks source link

Investigate report of translations sometimes not being submitted #426

Closed jbphet closed 1 year ago

jbphet commented 1 year ago

@solaolateju reported the following via SlacK:

This came from a translator this morning.\:

image

Assigning to myself to investigate.

jbphet commented 1 year ago

I've done some investigation, and I believe this problem was caused by a problem with the values in the rosetta-config.json file on the main server. I had neglected to add a value for PHET_IO_SERVER_URL when I made the recent change for xxx. I believe I have fixed the problem.

@solaolateju - Please ask the translator to retry their submission and let us know if there are any problems.

jbphet commented 1 year ago

I'm also going to leave this open and assigned to myself to verify that the logs look correct after this change has been in place for a while. If this is working correctly, we should see no more entries in Rosetta's log after this moment that say:

info: getting dependencies from undefined/sims/

...and we should see some that say:

info: getting dependencies from https://phet-io.colorado.edu/sims/

jbphet commented 1 year ago

I just verified that Rosetta's log looks correct based on the criteria specified in the previous comment. Since the code change was committed and integrated there are no instances of trying to get dependencies from "undefined..." and nine for getting dependencies from "phet-io.colorado.edu...". Lookin' good, closing.