search

phetsims / scenery-phet

Reusable components based on Scenery that are specific to PhET simulations.
MIT License
8 stars 6 forks source link

Component icons should generally be hidden in the PDOM #679

Open jessegreenberg opened 3 years ago

jessegreenberg commented 3 years ago

From phetsims/fourier-making-waves#73.

Component icons should generally be hidden in the PDOM. Sometimes icons are created programmatically and may have interactive content. The scenery-phet component generally makes the icon pickable: false, and it should similarly be removed from the PDOM so it is not focusable or discoverable with a screen reader. Accessibility for the component almost always goes through the component itself and does not involve the graphical icon.

This issue is to review scenery-phet components and make their icons pdomVisible: false where appropriate so that issues like phetsims/fourier-making-waves#73 don't come up again.

zepumph commented 2 years ago

Maybe a subset of https://github.com/phetsims/scenery/issues/1298?

jessegreenberg commented 1 year ago

https://github.com/phetsims/sun/issues/706#issuecomment-1285676276 Is an example for this issue.