search

phetsims / sherpa

Third-party libraries and dependencies for PhET Simulations
http://scenerystack.org/
Other
8 stars 8 forks source link

Remove older json-diff-patches #74

Closed samreid closed 6 years ago

samreid commented 6 years ago

We upgraded to a new jsondiffpatch for phet-io API diff tool. We should move forward usages of the old versions, and delete the old version.

samreid commented 6 years ago

I messaged slack:

Large multi-repo commit incoming to update jsondiffpatch, discussed in https://github.com/phetsims/sherpa/issues/74

I updated jsondiffpatch 0.1.31 usages to v0.3.11, and tested with phetioEmitDeltas=true and it appears to be working nicely. I tested aqua to see if anything was disturbed and it seemed to check out. Pushing shortly.

samreid commented 6 years ago

After commits, we have only one version of jsondiffpatch now, closing.

samreid commented 6 years ago

Bayes CT is showing a lot of Error: Unable to read "../sherpa/licenses/jsondiffpatch-v0.3.11.umd.js.txt" file (Error code: ENOENT)., I'll look into it.

samreid commented 6 years ago

Proposed fix tested locally and pushed. Closing again--will reopen if Bayes CT finds other problems.