search

phetsims / sherpa

Third-party libraries and dependencies for PhET Simulations
http://scenerystack.org/
Other
8 stars 8 forks source link

Use FA4 scissors instead of FA5 #87

Closed chrisklus closed 3 years ago

chrisklus commented 3 years ago

In https://github.com/phetsims/sherpa/issues/85, we decided that FA4 icons can still be used when more desirable, and the scissors was an icon that most people preferred from FA4. I believe the new shape from FA5 that's currently in use is cutSolidShape. I see usages in CCK, ESP, and Expression Exchange.

@samreid I'm not familiar with FA and how to bring back a FA4 icon - would you be up to do this and then either replace the three usages or assign to responsible devs to do theirs?

samreid commented 3 years ago

I converted to use the FA4 scissors, and tested in the relevant sims. @chrisklus would you like to double check?

samreid commented 3 years ago

This has been ready for review since July 27. @chrisklus can you please review or reassign to me to find another reviewer?

chrisklus commented 3 years ago

My apologies - commits look good, the scissors look as expected in the relevant sims, and i see no further usages of the FA5 scissors.

Closing.