Open samreid opened 1 year ago
@zepumph and I discussed that this may be prohibitively expensive to fix and maintenance release for hydrogen, but would be good to address as a "breaking change" for helium. We will discuss at upcoming phet-io meeting.
Should we make a helium label?
Proposed patch:
I renamed the issue since we went through all usages of StateSchema.asValue.
We made a project board to capture this data and schedule changes for this.
Create some logic in IOType that ensures that stateSchemas MUST be provided if toStateObjects are.
Let's do that now.
I added this patch and immediately ran into trouble. We have toStateObjects for VoidIO, ObjectIO, and likely others, but no state schema. That doesn't seem right. Let's work on that!
Ok. I don't think I can get to a commit point here. I found 3 spots where we weren't supplying stateSchema but should have been. I added this into the patch from above, so that the below is just about all work we want to do for this issue. Likely some of these API changes will never be worth it. We will just have to see.
From https://github.com/phetsims/tandem/issues/303