search

phetsims / trig-tour

"Trig Tour" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/trig-tour
GNU General Public License v3.0
2 stars 2 forks source link

Background for dizzyPhetGirl should be transparent #57

Closed jessegreenberg closed 9 years ago

jessegreenberg commented 9 years ago

The new PhET girl image looks great! However, I notice that the image background is not transparent so it looks a little strange when it pops up. It blocks much of the simulation and makes PhET girl look off center. I am wondering if the dizzyPhetGirl image background should be transparent?

This is unrelated to code review, and is more of a design question. If the look is as it is intended, feel free to close. @amanda-phet do you have any thoughts on this?

background_alpha

amanda-phet commented 9 years ago

It is supposed to be transparent, and I gave @dubson the correct .png. Perhaps he hasn't updated it?

amanda-phet commented 9 years ago

It looks like the images folder has a .jpeg and a .png. The .jpeg should be deleted so that it is never used, and the .png should be used. The .ai asset needs to be uploaded by @dubson as well.

jessegreenberg commented 9 years ago

.jpeg has been deleted for the dizzyPhetGirl, and the .png is being used. Image background is now transparent. There is another issue open for adding the image asset, so this can be closed.