search

phetsims / trig-tour

"Trig Tour" is an educational simulation in HTML5, by PhET Interactive Simulations.
http://phet.colorado.edu/en/simulation/trig-tour
GNU General Public License v3.0
2 stars 2 forks source link

sim relies on align:'right' default for Panels #82

Closed pixelzoom closed 8 years ago

pixelzoom commented 8 years ago

Related to https://github.com/phetsims/sun/issues/252, this sim relies on the old default of align:'right' for Panels. Below are the stack traces for occurrences that need to be checked. These are the occurrences noted when loading the sim in requirejs mode. If the sim creates Panels dynamically, you should do further checking with fuzzMouse.

>>>> sim relies on align:right
VM29982 Panel.js?bust=1472165064666:54 Error
    at ControlPanel.Panel [as constructor] (http://localhost/~cmalley/GitHub/sun/js/Panel.js?bust=1472165064666:50:15)
    at new ControlPanel (http://localhost/~cmalley/GitHub/trig-tour/js/trig-tour/view/ControlPanel.js?bust=1472165064666:102:11)
    at new TrigTourScreenView (http://localhost/~cmalley/GitHub/trig-tour/js/trig-tour/view/TrigTourScreenView.js?bust=1472165064666:78:24)
    at TrigTourScreen.Screen.call.backgroundColor [as createView] (http://localhost/~cmalley/GitHub/trig-tour/js/trig-tour/TrigTourScreen.js?bust=1472165064666:34:34)
    at TrigTourScreen.initializeView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165064666:134:25)
    at TrigTourScreen.initializeModelAndView (http://localhost/~cmalley/GitHub/joist/js/Screen.js?bust=1472165064666:151:12)
    at initializeScreen (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165064666:441:14)
    at Array.forEach (native)
    at new Sim (http://localhost/~cmalley/GitHub/joist/js/Sim.js?bust=1472165064666:439:13)
    at http://localhost/~cmalley/GitHub/trig-tour/js/trig-tour-main.js?bust=1472165064666:36:15
pixelzoom commented 8 years ago

None of the above call sites use the minWidth option, so their behavior will be unaffected. Closing.