Updates to slider ranges, defaults, constrainValue

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.

MIT License

19 stars 5 forks source link

Closed arouinfar closed 5 years ago

arouinfar commented 5 years ago

Due to the changes in #370, the ranges, defaults, and constrainValues specified in https://github.com/phetsims/wave-interference/issues/363#issuecomment-481031114 will need some updating.

Circle Diameter, Square Width/Height, Waving Girl Height should have the same values

The other sliders are still looking good.

samreid commented 5 years ago

Updated in the commit, @arouinfar can you please review? Close if all is well.

arouinfar commented 5 years ago

@samreid the updates are all looking good.

In reviewing the changes, I noticed a few more things that need updating.

[x] Square, Circle & Square, and Lattice scenes - units still need to be updated to mm
[x] Circle & Square scene - update tweakers to 0.01 mm

samreid commented 5 years ago

Proposed fixes pushed, @arouinfar can you please take a look?

arouinfar commented 5 years ago

Looks good @samreid