search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
19 stars 5 forks source link

Should the sound wave tone and corresponding checkbox appear in Wave Interference 2.0? #392

Closed samreid closed 5 years ago

samreid commented 5 years ago

We are developing the sound wave tone and "Play Tone" checkbox as part of the Waves Intro sim, but I don't recall if we discussed adding it to Wave Interference itself. @arouinfar @kathy-phet @ariel-phet what do you recommend?

kathy-phet commented 5 years ago

Yes, that would be good.

Kathy

Sent from my iPhone

On May 7, 2019, at 8:31 AM, Sam Reid notifications@github.com<mailto:notifications@github.com> wrote:

Assigned #392https://github.com/phetsims/wave-interference/issues/392 to @kathy-phethttps://github.com/kathy-phet.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/phetsims/wave-interference/issues/392#event-2324408478, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABG4KZF7JRFWGNJQKBCDCSTPUGHCNANCNFSM4HLJNYFQ.

arouinfar commented 5 years ago

Agreed with @kathy-phet. We should include Play Tone in Wave Interference, but I think it can wait until 2.0.

ariel-phet commented 5 years ago

@kathy-phet decision works for me.

samreid commented 5 years ago

@kathy-phet and @arouinfar: should the "Play Tone" button appear only on the "Waves" screen, or also on the "Interference" and "Slits" sceens?

arouinfar commented 5 years ago

I think we'd only want "Play Tone" on the Waves screen.

For Interference and Slits, we'd need some sort of microphone-like probe to place in the lattice. Playing a single tone on these screens would be problematic, since the interference pattern would alter the sound. I think such a tool would be beyond the scope of Wave Interference, anyway.

samreid commented 5 years ago

Working on this, I've noted the problem that the sound tone plays on other scenes. We will need to associate it with a more specific node to get it to enable/disable correctly.

samreid commented 5 years ago

I fixed the problem in the preceding comment and enabled the sine wave oscillator tone and control for Wave Interference's "Waves" screen. @arouinfar can you please test Wave Interference and Waves Intro to make sure the tone and its control are behaving as desired?

arouinfar commented 5 years ago

@samreid looks good in waves-intro and wave-interference.

samreid commented 5 years ago

Excellent, thanks for testing, closing.