search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
19 stars 5 forks source link

Lines in color slider #402

Closed ghost closed 5 years ago

ghost commented 5 years ago

For https://github.com/phetsims/QA/issues/322. There are lines visible in the color sliders. The lines are more prominent on macOS, but they are there on Windows.

2.0.0-dev.1: Screen Shot 2019-05-24 at 4 21 31 PM

Published version: Screen Shot 2019-05-24 at 4 21 13 PM

Do we want the lines or is this a regression?

arouinfar commented 5 years ago

Looks pretty awful in latest macOS/Chrome.

image

However, the slider looked fine in 1.1.0-dev.5 (version just prior to 2.0.0-dev.1) image

KatieWoe commented 5 years ago

Shows up with less severity in Windows 10 chrome: lessbutstillthere

KatieWoe commented 5 years ago

May be connected to https://github.com/phetsims/blackbody-spectrum/issues/95

samreid commented 5 years ago

And likewise https://github.com/phetsims/scenery-phet/issues/500

pixelzoom commented 5 years ago

I'm guessing that you picked up phetsims/scenery-phet#500 while work was in progress. Please confirm.

pixelzoom commented 5 years ago

I see no evidence of this problem in master, so you almost certainly picked up intermediate work and hit this problem: https://github.com/phetsims/scenery-phet/issues/500#issuecomment-495409067

I'm not sure how we avoid this kind of thing in the future - the "in-progress" label was removed, and any work in progress might impact any sim. But it wouldn't hurt to ask on Slack before publishing something that will be tested by QA.

pixelzoom commented 5 years ago

... and I think it's safe to simply close this issue, after confirming for yourself.

samreid commented 5 years ago

I do not see the problem in master at the moment, closing.