Long strings push wavelength box into slit box

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.

MIT License

19 stars 5 forks source link

Long strings push wavelength box into slit box #404

Closed ghost closed 5 years ago

ghost commented 5 years ago

For https://github.com/phetsims/QA/issues/322. Apologies for not using correct terminology.

I'm not sure if you've had a chance to look over the 4th screen for internationalization issues. Here's what stringTest=double looks like right now:

Screen Shot 2019-05-24 at 4 50 55 PM

Looks worse with stringTest=long.

I haven't seen any issues with screens 1-3.

samreid commented 5 years ago

I'll work on the i18n of the wavelength slider after #396 is complete, thanks!

samreid commented 5 years ago

Thanks for reporting this @lmulhall-phet. I addressed it in the commit. Can you or @KatieWoe or @arouinfar please review/test?

KatieWoe commented 5 years ago

Looks good to me @samreid

arouinfar commented 5 years ago

Looks good @samreid, thanks!