search

phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
19 stars 5 forks source link

Should the timer be above the reset button in z-ordering? #434

Closed ghost closed 5 years ago

ghost commented 5 years ago

For https://github.com/phetsims/QA/issues/405. I looked through the repo and I didn't see any similar issues, so if there is one, feel free to close this one.

I'm wondering if the timer should be above (in front of) the reset button.

Screen Shot 2019-08-18 at 10 50 15 AM

Seems to happen in all screens with a timer in both Wave Interference and Waves Intro.

samreid commented 5 years ago

This is a new problem, not in the published version.

samreid commented 5 years ago

Fixed in master and will need to be cherry-picked to the branch for next RC

arouinfar commented 5 years ago

I thought we generally had a (likely unwritten) rule about keeping ResetAllButton on top of everything else? Might be worth checking in with #dev-public, if we haven't already. Thoughts @samreid?

I don't really have a strong opinion when it comes to this issue. If a user occludes the ResetAllButton by moving a tool in front of the button, they can just move the tool out of the way.

samreid commented 5 years ago

@pixelzoom said:

In general, fixed-position UI components are typically behind moveable UI components.

KatieWoe commented 5 years ago

This seems fixed in the new rc. Before closing, I had a related z-ordering question. Should an object being picked up and moved be moved to the front? I think we did something similar in gas properties. @arouinfar? zorderbetweenmovement

arouinfar commented 5 years ago

@KatieWoe, yes the active tool generally pops to the front.

@samreid can you adjust the z-ordering of the tools so that the active one pops to the front?

samreid commented 5 years ago

Thanks, I opened #450 about moving tools to the front. This issue can be closed.