phetsims / wave-interference

"Wave Interference" is an educational simulation in HTML5, by PhET Interactive Simulations.
MIT License
19 stars 5 forks source link

Safari: timer restart button is darker in toolbox #514

Open KatieWoe opened 3 years ago

KatieWoe commented 3 years ago

Device MacBook Air and iPad 6th Gen OS MacOS 10.15 and iPadOS 14.3 Browser Safari Problem Description For https://github.com/phetsims/QA/issues/580. Does not occur in published. The restart timer button on the timer is disabled while it is in the toolbox since the timer is at 0. However, in Safari, what that looks like in the box and out of the box is different. In the box, the button is darker. Out of the box, and in other browsers, the button is lighter. Visuals: Win 10 Chrome:

buttoncolorwinchrome

On iPad: Image from iOS (1) Image from iOS

samreid commented 3 years ago

I wonder if a filter is getting applied twice?

samreid commented 3 years ago

@jonathanolson does this seem like it is related to the scenery filters?

samreid commented 3 years ago

I confirmed this problem is happening on Mac Safari but not Mac Chrome on https://phet-dev.colorado.edu/html/waves-intro/1.1.0-rc.3/phet/waves-intro_all_phet.html. It is also happening on master.

In https://github.com/phetsims/wave-interference/blob/59b11a8d85d026ccd33c681859bc9e66e5d87e74/js/common/view/ToolboxPanel.js#L54 the stopwatch is rasterized. If I remove the rasterization step, the problem goes away--this suggests that color filters are incorrect for Safari.

To test this hypothesis, I tried taking a screenshot on Safari. In this screenshot, the top is the live sim and the bottom is the screenshot. Please ignore the yellow highlight:

image

I'll open a scenery issue.

jonathanolson commented 3 years ago

Yes, seems like https://github.com/phetsims/scenery/issues/1142. Is this blocking for this sim (presumably?)

arouinfar commented 3 years ago

In https://github.com/phetsims/scenery/issues/1142#issuecomment-764834443 we decided this is not a blocking issue.

samreid commented 3 years ago

On hold until https://github.com/phetsims/scenery/issues/1142 has progress.