phil294 / GitLG

A free, interactive Git UI for VSCode
MIT License
156 stars 16 forks source link

Add typechecking to build process #118

Open alexrecuenco opened 4 days ago

alexrecuenco commented 4 days ago

I set typescript version to 5.6 until this is fixed, which will likely be soon

alexrecuenco commented 4 days ago

I wouldn't be confident merging this until the linting issues are fixed, and we see the job get all the way to the build step.

I run it locally however and there are some type issues to address

Found 565 errors in 19 files.

Errors  Files
    13  ../node_modules/lodash.isregexp/index.js:11
    13  ../node_modules/postcss-sanitize/index.js:6
     1  ../src/extension.js:7
     1  main.js:1
   489  node_modules/vue-virtual-scroller/dist/vue-virtual-scroller.umd.js:3
    14  src/components/PromiseForm.vue:19
     1  src/directives/drop.js:36
     4  src/directives/moveable.js:21
     3  src/state/commit-stats.js:75
     1  src/state/store.js:129
     5  src/utils/log-parser.js:219
     1  src/views/AllBranches.vue:10
     1  src/views/CommitDetails.vue:151
     4  src/views/CommitRow.vue:21
     1  src/views/CommitsDetails.vue:60
     3  src/views/GitInput.vue:27
     1  src/views/History.vue:16
     4  src/views/MainView.vue:42
     5  src/vue-app.js:4

Although I think the Vue Extension really dislikes the jsconfig.json, and it would prefer that file be called tsconfig.json (you can still set it to allowJS: true and checkJS: true)