search

phil294 / GitLG

A free, interactive Git UI for VSCode
MIT License
156 stars 16 forks source link

Light theme support? #13

Closed lens0021 closed 1 year ago

lens0021 commented 1 year ago

I use either the light theme or the dark theme, but I don't want to mix them up. When I switch to a light theme, the windows of this extension remain dark.

image

lens0021 commented 1 year ago

I did not read 8c55bc2

phil294 commented 1 year ago

yes it's not cool - not only does it not respect light theme setting, it also mostly ignores the color scheme of the currently selected global theme and just ships its own colors everywhere. The main problem is the branch colors - finding a set of colors that look okay-ish both on a dark and on a light background is difficult, and I in particular am pretty bad at these kinds of things, so I gave up.

However, as always, it would be better if theme alignment could still be enabled with a setting at least, so I will do that for the next update.

lens0021 commented 1 year ago

The PR I've uploaded is PoC of using filters and here is an example:

image