Some opinions/questions

[hansu]

1. Is it possible to make make this part hideable via a setting or hide this with a button? It's a bit space consuming.

2. I only found how to add buttons. Would be nice to be able to hide these buttons here.

3. This seems to have a smaller font than the other text in the main view. I would be nice if all text has the same font size and style. Maybe except the commit hash.

4. I think a thin line width in the same color as the branch for the rounded rectangle might look better here.

5. I think the white background with is blended as a thick line is too much here. The filled bubbles would be sufficient here as highlighting.

6. The up and down buttons for "stash" and "pop stash" look more like navigating buttons and could lead to accidentally pushing or popping the stash.

[phil294]

Thanks for the feedback, much appreciated. I consider achieving an intuitive and aesthetic interface to be an integral, if not the core part of this extension, so getting this right is important. There is still lots to do and the more input you guys provide, the better.

1. Is it possible to make make this part hideable via a setting or hide this with a button? It's a bit space consuming.

Yes, it's "git-log--graph.hide-quick-branch-tips": true. Is that enough?

2. I only found how to add buttons. Would be nice to be able to hide these buttons here.

these buttons are the exact same list of actions that also appear via context menu (right click). Do you mean to be able to remove actions from that list entirely or to just hide all buttons in the right area?

If the former: This used to be possible, but it means that you'd then need to copy all existing action data in order to modify something. The default actions is currently a 400 line json file and will continue to grow. This is a nightmare to handle in settings.json and also bloats it up unnecessarily and introduces upgrade problems for when we add new default actions. That's why I just decided to make it impossible to take away from the default actions. Open for ideas though, of course.

But you were probably referring to the latter anyway, to just hide the buttons.

I guess it would be nice to move / remove all areas of the interface. But I'm not sure what the best approach would be. The settings UI which VSCode offers for both its own settings and extension settings is pretty annoying to deal with imo, you never find the important settings and are just lost in between thousands of other minor ones. That's why I personally prefer buttons and in-UI-settings instead of the external settings.json approach, but that's not really in the spirit of the IDE...

Apart from user settings.json, there is workspace settings, folder settings and there is also the possibility of storing config as "extension state", an API offered to extensions to store preferences without them being visible to the user. That's what is in use already for the git action command overwrite save text stuff, for example. And finally, extensions can even write to user / workspace settings, so both approaches could be unified. I never really know where to store config data, so I think the sanest approach would be to just add a new "git-log--graph.hide-side-bar-buttons" setting which will then hide the buttons for commits, branches and stashes, but keep the context menu as is.

16 will add custom CSS so there will be another solution for removing stuff.

3. I would be nice if all text has the same font size and style

agree

4. I think a thin line width in the same color as the branch for the rounded rectangle might look better here.

I'm afraid it won't look prominent enough, especially because the branch colors are not predictable and perhaps a brown border color may not really be obvious. But I guess it's worth a try

5. The filled bubbles would be sufficient here as highlighting.

also agree

6. The up and down buttons for "stash" and "pop stash" look more like navigating buttons and could lead to accidentally pushing or popping the stash.

yeah it's not great. But I couldn't find anything better fitting from codicon icons without conflicting with the icons of other actions.

[hansu]

Hope you had a nice vacation :slightly_smiling_face:

Yes, it's "git-log--graph.hide-quick-branch-tips": true. Is that enough?

Yes, great! I looked at the settings section but I didn't associate the setting's name with that function, so I didn't read the description.

Maybe something like "git-log--graph.hide-git-status" would be more intuitive.

these buttons are the exact same list of actions that also appear via context menu (right click). Do you mean to be able to remove actions from that list entirely or to just hide all buttons in the right area?

hide all or specific buttons only from the right area to have more space when many files have been changed

That's why I personally prefer buttons and in-UI-settings instead of the external settings.json approach, but that's not really in the spirit of the IDE...

I like the concept of having the settings for all extensions in one central file... ;)

so I think the sanest approach would be to just add a new "git-log--graph.hide-side-bar-buttons" setting which will then hide the buttons for commits, branches and stashes, but keep the context menu as is.

Yeah go for it. Or maybe use "git-log--graph.show-side-bar-buttons" to not have the double inverted logic.

[hansu]

Yes, it's "git-log--graph.hide-quick-branch-tips": true. Is that enough?

Yes, great! I looked at the settings section but I didn't associate the setting's name with that function, so I didn't read the description.

Hmm not 100% what I wanted. This setting hides the git status area and also the nice branch names at the top of the branches (red rectangle).

Maybe have two settings - "git-log--graph.hide-quick-branch-tips" to disable the branch names (red rectangle), and "git-log--graph.hide-git-status` to hide the git status area.

[phil294]

5. I think the white background with is blended as a thick line is too much here. The filled bubbles would be sufficient here as highlighting.

I'm not sure on this anymore, for example here:

I think it's helpful to have the line be somehow highlighted as there are no commits to show this otherwise. But still it's a bit too... much right now

[hansu]

If you don't have any commits of your checked out branch in view - then I wonder why it's necessary to highlight that line. I never missed the highlighting of the current branch line in Git Graph and I don't know a git tool which does that. If you want stick to highlighting - maybe a thicker line would be sufficient?

[hansu]

I think a thin line width in the same color as the branch for the rounded rectangle might look better here.

Yeah looks much better with having that frame in the same colour. And I also like the decent highlighting of the active branch line :+1:. Thanks for that!

I also appreciate ecba6c8a7150b5e43b92c689cdc5334e9c768cb1

I think 3a0d7cd76ec7c954796e762faf6b9e17b8bc90f0 broke the displaying of the images inside VSCode. Maybe you have to use absolute links now.

And a changelog which shows inside VSCode would be nice 😇

[hansu]

I think it's a bit suboptimal that either the branch name or the commit message is hidden when the branch name is longer than the remaining space in that column:

Sometimes on long branch names and short commit messages the commit message is completely hidden.

Do you think it's possible to move the commit message right to the branch name like so?:

[phil294]

Do you think it's possible to move the commit message right to the branch name like so?

That's the plan, see #44

[phil294]

(...)

thanks for the feedback!

I think 3a0d7cd broke the displaying of the images inside VSCode. Maybe you have to use absolute links now.

yes but this is just because of a version mismatch between GitHub and the released version, so it will fix itself with next update

And a changelog which shows inside VSCode would be nice 😇

What do you mean by that? Isn't this enough?

Or perhaps you mean to add a new command such as git log --graph: Show Changelog ?

[hansu]

Do you think it's possible to move the commit message right to the branch name like so?

That's the plan, see https://github.com/phil294/git-log--graph/issues/44

Oh, nice :+1:

And a changelog which shows inside VSCode would be nice innocent

What do you mean by that? Isn't this enough?

Oh I didn't expect it to be at the very bottom of the Details tab, because most of the extensions have it in a separate tab like this:

[phil294]

I didn't know this exists. I will move it there

[hansu]

I didn't know this exists. I will move it there

It's probably not more than moving the content to a file named CHANGELOG.md

[phil294]

indeed, just had to create the file :-)

[phil294]

The up and down buttons for "stash" and "pop stash" look more like navigating buttons and could lead to accidentally pushing or popping the stash.

changed them to something else now. Still not great but at least no arrows anymore