Enhance Find Mode Performance and Responsiveness - Githubissues

philc / vimium

The hacker's browser.

https://chrome.google.com/webstore/detail/vimium/dbepggeogbaibhgnhhndojpepiihcmeb

MIT License

23.21k stars 2.48k forks source link

Enhance Find Mode Performance and Responsiveness #4546

Open darpham opened 2 weeks ago

darpham commented 2 weeks ago

Problem Statement:

When using find mode (/) on large web pages, searching is slow to the point of unusable. Reproducible via https://nix-community.github.io/home-manager/options.xhtml.

Planned Improvements:

[ ] Delay / debounce FindMode.findInPlace() to reduce the frequency of searches during typing.
- InReview https://github.com/philc/vimium/pull/4547
[ ] Implement a caching mechanism for text nodes, potentially using SimpleCache from ./lib/utils.js.
[ ] Offload text searching to a Web Worker or run asynchronously, possibly utilizing AsyncDataFetcher from ./lib/utils.js.

Expected Benefits:

Improved responsiveness during rapid typing in find mode.
Faster search performance, especially on large web pages.
Reduced strain on system resources during find operations.

UncleSnail commented 1 week ago

The first task should be sufficient. The second two are good ideas, but are probably unneeded and would introduce unnecessary complexity. I like the idea for the debounce though, and this is a real issue. It also freezes on your example page on my machine. I'm going to take a look at your PR.