search

phillco / talon-axkit

Talon macOS accessibility magic!
MIT License
45 stars 12 forks source link

all: reformat Talon using `talonfmt` #36

Closed phillco closed 2 years ago

phillco commented 2 years ago

Similar to https://github.com/knausj85/knausj_talon/pull/947, let's use talonfmt, although I prefer a slightly longer maximum line length.

Note that one change to notification.talon is working around a parser issue: https://github.com/wenkokke/talonfmt/issues/17

wenkokke commented 2 years ago

Wouldn’t it make sense to match the line width, especially if this should eventually be upstreamed?

phillco commented 2 years ago

I'd actually propose that we change the knausj width to 88 to match black, or even 100. I didn't realize how many rules would be split up onto multiple lines with a limit of 80, which I think makes them a bit more cumbersome to modify later. I'll raise that in knausj though.

wenkokke commented 2 years ago

Please use 1.8.0, which fixes the issues with negative numbers and private identifiers.