philnash / pwned

😱 An easy, Ruby way to use the Pwned Passwords API.
https://rubygems.org/gems/pwned/
MIT License
424 stars 22 forks source link

Environment proxy #25

Closed philnash closed 3 years ago

philnash commented 3 years ago

Builds on the work from #24. Restores the default behaviour of Net::HTTP with an environment set HTTP proxy. Documents the changes in comments and the README.

I think we actually broke the default behaviour of Net::HTTP when introducing the proxy option in #21. I see this as fixing that, plus allowing for users to declare their own explicit proxy and choose to ignore the environment proxy if they want to (much as the faraday gem does).