Add .kra (Krita documents) to zip adapter

phiresky / ripgrep-all

rga: ripgrep, but also search in PDFs, E-Books, Office documents, zip, tar.gz, etc.

Other

6.4k stars 148 forks source link

Add .kra (Krita documents) to zip adapter #208

Closed duxovni closed 2 weeks ago

duxovni commented 5 months ago

Krita documents are also zip archives, but the accurate matcher doesn't seem to be recognizing them properly. More generally, it'd be nice to have the ability to configure extra associations of file extensions to integrated adapters, rather than needing a patch for every new filetype that's actually a zip archive.

lafrenierejm commented 1 month ago

@duxovni Mind rebasing?

duxovni commented 1 month ago

Done!

On May 8, 2024 7:49:22 PM EDT, Joseph LaFreniere @.***> wrote:

@duxovni Mind rebasing?

-- Reply to this email directly or view it on GitHub: https://github.com/phiresky/ripgrep-all/pull/208#issuecomment-2101674217 You are receiving this because you were mentioned.

Message ID: @.***>

phiresky commented 2 weeks ago

seems fine though I'm not sure how useful searching krita files is? I'd expect them to only / mostly just have picture / vector data. Note that every file search takes up compute time so enabling this might have a negative impact esp. since krita files are probably large.

Yes, being able to configure the extensions of the zip adapter sounds useful if someone wants to make a PR.