search

phiweger / zoo

A portable datastructure for rapid prototyping in (viral) bioinformatics (under development).
5 stars 2 forks source link

sourmash v2 breaks stuff #116

Closed phiweger closed 7 years ago

phiweger commented 7 years ago

https://github.com/dib-lab/sourmash/commit/564f89d319e899fe5220c9644d7984e1b1f9053f

update Estimators class to MinHash

luizirber commented 7 years ago

There might be extra breakage if https://github.com/dib-lab/sourmash/pull/164 is merged (still discussing it), but overall do you think these changes clarify the API and make it easier to use?

phiweger commented 7 years ago

Definitely, and as it turns out I only had to change a tiny amount of code, mainly connected to the Estimators class, which I thought was an odd name anyway. So yeah, IMO the v2 sourmash API changes are an improvement.