search

phlask / phlask-map

Code behind the Phlask Web Map
https://beta.phlask.me
34 stars 36 forks source link

[V2] Cleanup old Add Resource and Display Resource code #414

Closed vontell closed 5 months ago

vontell commented 7 months ago

Is your feature request related to a problem? Please describe. Now that we are updating the code that uploads and pulls the resources, we have identified a few potential places where V1 code is no longer used, and is confusing to update. This ticket is to remove a few older parts of the Add Resource code and code related to pulling and displaying resoueces that is no longer used. This will help us with our next ticket, #415

Describe the solution you'd like Remove old code that is no longer used related to adding resources and displaying resources. For instance, the AddTapModal. You can also search for @deprecated for a few components that @Erw1nn marked as deprecated.

vontell commented 7 months ago

@Erw1nn I made this ticket last week, and just realized you went and marked some of these as deprecated recently. Just wanted to confirm if this ticket is ok with you, I was thinking of having someone remove these fairly soon since it will help new folks understand the codebase a little better.

Erw1nn commented 7 months ago

@Erw1nn I made this ticket last week, and just realized you went and marked some of these as deprecated recently. Just wanted to confirm if this ticket is ok with you, I was thinking of having someone remove these fairly soon since it will help new folks understand the codebase a little better.

Yeah that's totally fine!

vontell commented 5 months ago

This is now complete as well.