search

phoenixframework / phoenix_pubsub

Distributed PubSub and Presence platform for the Phoenix Framework
http://www.phoenixframework.org/
MIT License
653 stars 124 forks source link

topic forced to be string #147

Closed artemk closed 4 years ago

artemk commented 4 years ago

Hi guys. Any reason you force topic to be string?

I have no problem using tuple instead of string, but dialyzer claims because it expect topic to be string.

phash2, which is used inside, accepting term as a first argument. So any reason to force it to be string in lib?

chrismccord commented 4 years ago

Given different PubSub adapters and potential future features, such as wildcard broadcasts (not planned), it was locked down initially. A future pubsub release will likely open this up to support other terms, but not in the immediate future. Thanks!