search

phoenixframework / phoenix_pubsub

Distributed PubSub and Presence platform for the Phoenix Framework
http://www.phoenixframework.org/
MIT License
653 stars 124 forks source link

Rename first adapter in the pool for backwards compatability #169

Closed Gazler closed 2 years ago

Gazler commented 2 years ago

Pubsub v2.0 expects there to be a single process for the process group named Elixir.my_pubsub.Adapter.

v2.1 added pools, which means that the processes are supervised with a supervisor called Elixir.my_pubsub.Adapter along with n processes named Elixir.my_pubsub.Adapter_n where n is the pool size.

This commit changes the supervisor name to Elixir.my_pubsub.Adapter_supervisor and renames pool item 1 to be Elixir.my_pubsub.Adapter. This will allow backwards compatability with v2.0 when the pool size is set to 1.

chrismccord commented 2 years ago

Thanks. I will cut a new 2.1.1. This also closes #168 ❤️❤️❤️🐥🔥