phoenixlauncher / phoenix

A lightweight game launcher written in SwiftUI for macOS!
https://phoenixlauncher.app
MIT License
130 stars 11 forks source link

General weirdness when adding/deleting games #104

Closed Shock9616 closed 10 months ago

Shock9616 commented 10 months ago

https://github.com/phoenixlauncher/phoenix/assets/28808006/fdd9a65a-fb6b-45d5-b177-1ede371c9b67

Apologies for the terrible quality. I had to export at 480p and then compress it a ton to get it under 10mb 😅

There's a fair amount of weirdness when managing games in the game list. My initial thought is that it might be similar/related to the issue with icons getting messed up in #93, but I have no idea if that's actually the case.

As seen in the video, creating a game called "Test 1" appears to take over the name for "The Witcher" in my game list, but doesn't seem to do anything else, and after creating a "Test 2" and deleting "Test 1", "The Witcher"'s spot gets replaced with "Test 2" until that game is also deleted (which causes a crash). Also, when deleting a game either called "Untitled" or "Untitled Goose Game" (because I couldn't make a game called "Untitled 2", we should add the ability to create a game even when it's not found in the database) it just crashes.

Again, I'm guessing this is at least somewhat similar to the icon issue from before, so whatever fixed that would probably be a good place to start.