phoenixlauncher / phoenix

A lightweight game launcher written in SwiftUI for macOS!
https://phoenixlauncher.app
MIT License
130 stars 11 forks source link

Unintentional "Multiple Games Selected" on startup #176

Closed Shock9616 closed 1 month ago

Shock9616 commented 3 months ago

NOTE: Please submit website issues here

Describe the bug When opening the app, if the previously selected game (i.e. the one that will be selected on startup) isn't visible on the list, selecting another game without first making it visible will result in the "Multiple Games Selected" screen showing up.

To Reproduce Steps to reproduce the behavior:

  1. Select a game that is far enough down the list that it isn't shown on startup
  2. Close/reopen the app
  3. Select a game that is visible without scrolling
  4. The multiple games selected screen

Expected behavior The games should be selected/deselected as intended

Screenshots https://github.com/user-attachments/assets/83c2264e-29eb-4b3a-9cd7-12bfe70ba727

Logs Find the logs by pressing CMD+Shift+O in Phoenix, or going to ~/Library/Application Support/Phoenix log_2024-08-23 17:53:42.693000.log

Desktop (please complete the following information):

Additional context This bug goes away once the initially selected game has been made visible in the list. It just has to be visible at least once before another game is selected

Shock9616 commented 1 month ago

Decided to try and figure this bug out this evening, but when I tried to replicate it nothing went wrong? I tried it on v0.1.10 (33) just like before and there were no issues. I'm wondering if it was actually a bug in SwiftUI itself that got fixed with the new toolchain alongside Sonoma?

Can anyone else quickly verify that it's also fixed for them and it's not just me going crazy? It'd be great if someone test on Sonoma so that we can verify that's how the bug was fixed.

Shock9616 commented 1 month ago

Closing for now since the issue seems to be resolved (at least on Sequoia). Will reopen if/when we find out it's still broken on Sonoma.