Use `rimraf` package instead of `rm -rf` in `preinstall` script

oltionchampari commented 3 years ago

Closes phovea/generator-phovea#404

Developer Checklist (Definition of Done)

[x] Descriptive title for this pull request provided (will be used for release notes later)
[ ] All acceptance criteria from the issue are met
[x] Branch is up-to-date with the branch to be merged with, i.e., develop
[x] Code is cleaned up and formatted
[ ] Code documentation written
[ ] Unit tests written
[x] Build is successful
[x] Summary of changes written
[ ] Wiki documentation written
[x] Assign at least one reviewer
[x] Assign at least one assignee
[x] Add type label (e.g., bug, enhancement) to this pull request
[x] Add next version label (e.g., release: minor) to this PR following semver

Summary of changes

Replaced
"preinstall": "rm -rf node_modules && rm package-lock.json || true"
"preinstall": "rimraf node_modules package-lock.json || exit 0"
When using rimraf node_modules in windows you get a warning since the package deletes itself. We could solve this if we are prepared to install rimrafglobally.
Replaced || true (throws an error in windows) with || exit 0which works for both windows and linux.
Tested the command both in windows and linux and the workspace installation works as expected.

Notes

Another windows incompatible script is: "build:python": "rm -rf build/source && find . -name '*.pyc' -delete && node buildPython.js && cp -r ./<%-name.toLowerCase()%> build/source/", Both the rm -rf and cp do not exist in windows. I do not know though if this needs to be windows compatible though.

ghost commented 3 years ago

@oltionchampari Thanks for the fix. I tried that new preinstall command with my PowerShell on Windows 10 (with 20H2) and got the following error (in German):
In Zeile:1 Zeichen:39
+ rimraf node_modules package-lock.json || exit 0
+                                       ~~
Das Token "||" ist in dieser Version kein gültiges Anweisungstrennzeichen.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : InvalidEndOfLine
Researching the error, I've found that the pipeline operators || and && have been introduced with PowerShell v7.0.0 (see PowerShell/PowerShell#9849). Hence, they will only work with the most recent PowerShell version.

@anita-steiner We need to decide if Windows users require the newest PowerShell or we change the preinstall command.

I will check the version: the version is 5.1.17763.1490

thinkh commented 3 years ago

Btw there are a lot of still other scripts that use the pipeline operators (&& and ||; see https://github.com/phovea/generator-phovea/pull/447). We might need to change it as well (depending on the PowerShell version).

ghost commented 3 years ago

so we need a solution for ps version >= 5.1

phovea / generator-phovea